jeka/utun2
1
0 Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

test(chat): exercise avatar transaction, schema, and key lookup failures

Browse Source
This commit is contained in:
evgeny committed 2026-10-27 05:12:35 +01:00
1 parent 8b16f40094
commit 65409f8c80
2 files changed
+154 -7
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

tests/Makefile.am
+2 -1
View File
@@ -323,7 +323,8 @@ test_chat_channel_LDFLAGS = -Wl,--wrap=EVP_DigestSign -Wl,--wrap=sqlite3_exec -W
test_group_avatar_sql_SOURCES = test_group_avatar_sql.c
test_group_avatar_sql_LDADD = $(LIBUTUN) $(COMMON_LIBS)
test_group_avatar_sql_LDFLAGS = -Wl,--wrap=sqlite3_bind_blob -Wl,--wrap=sqlite3_bind_int64 -Wl,--wrap=sqlite3_bind_text \
-Wl,--wrap=sqlite3_exec -Wl,--wrap=sqlite3_prepare_v2 -Wl,--wrap=sqlite3_step -Wl,--wrap=sqlite3_changes -Wl,--wrap=sqlite3_finalize
-Wl,--wrap=sqlite3_exec -Wl,--wrap=sqlite3_prepare_v2 -Wl,--wrap=sqlite3_step -Wl,--wrap=sqlite3_changes -Wl,--wrap=sqlite3_finalize \
-Wl,--wrap=sc_ed25519_sign
else
test_socket_monitor_LDFLAGS += -Wl,--wrap=read
endif
tests/test_group_avatar_sql.c
+152 -6
View File
@@ -14,6 +14,13 @@ static enum fault fault;
static const char* target;
static int bind_index, last_target, fail_rollback, fail_schema_rollback, releases_after_failed_rollback;
static unsigned image_number;
static int fail_sign;
extern int __real_sc_ed25519_sign(const uint8_t*, const uint8_t*, size_t, uint8_t*);
int __wrap_sc_ed25519_sign(const uint8_t* key, const uint8_t* data, size_t size, uint8_t* signature) {
if (fail_sign) { fail_sign = 0; DEBUG_WARN(DEBUG_CATEGORY_CHAT, "avatar test: signing failed"); return SC_ERR_CRYPTO; }
return __real_sc_ed25519_sign(key, data, size, signature);
}
static int matches(const char* sql) { return target && !strncmp(sql, target, strlen(target)); }
static int take(enum fault point, const char* sql, int index) {
@@ -110,23 +117,162 @@ static void retry(struct UTUN_INSTANCE* inst) {
unsigned before = events; assert(!publish(inst) && events == before + 1);
}
static int veto(void* arg) { (*(unsigned*)arg)++; return 1; }
static void candidate(struct UTUN_INSTANCE* inst, struct group_avatar_record* r, uint64_t version) {
assert(!group_avatar_get(inst, group_id, r)); r->version = version ? version : r->version + 1;
r->size = 1; r->data[0] ^= 0x77; SHA256(r->data, r->size, r->hash);
uint8_t key[32], bytes[GROUP_AVATAR_MAX + 64]; char channel[32]; ga_channel(group_id, channel);
assert(!topo_node_sqlite_channel_get_priv(CC(inst)->db, channel, key));
int length = ga_message(group_id, r, bytes);
assert(sc_ed25519_sign(key, bytes, (size_t)length, r->signature) == SC_OK); OPENSSL_cleanse(key, sizeof(key));
}
static void sql_regressions(struct UTUN_INSTANCE* inst) {
const char* queries[] = {"SELECT adm_tags,source,adm_tags_sig,deleted", "SELECT ed25519_privkey FROM channels",
"SELECT avatar_version,avatar_data", "SELECT name, owner_node_id", "UPDATE channels SET avatar_version="};
unsigned cases = 0;
for (unsigned query = 0; query < 5; query++) {
target = queries[query];
for (enum fault point = F_PREPARE; point <= F_FINALIZE; point++) {
if (point == F_CHANGES && query < 4) continue;
int bindings = point == F_BIND && query == 4 ? 5 : 1;
for (int bind = 1; bind <= bindings; bind++) {
bind_index = bind; fault = point; refused(inst); retry(inst); cases++;
}
}
}
const char* commands[] = {"BEGIN IMMEDIATE /* group avatar */", "COMMIT /* group avatar */"};
for (unsigned i = 0; i < 2; i++) { target = commands[i]; fault = F_EXEC; refused(inst); retry(inst); cases++; }
fail_sign = 1; refused(inst); assert(!fail_sign); retry(inst);
const char* triggers[] = {
"CREATE TEMP TRIGGER reject_avatar BEFORE UPDATE OF avatar_version ON channels BEGIN SELECT RAISE(ABORT,'avatar update'); END",
"CREATE TEMP TRIGGER reject_avatar BEFORE UPDATE OF avatar_version ON channels BEGIN SELECT RAISE(IGNORE); END"
};
for (unsigned i = 0; i < 2; i++) {
assert(sqlite3_exec(CC(inst)->db, triggers[i], NULL, NULL, NULL) == SQLITE_OK); refused(inst);
assert(sqlite3_exec(CC(inst)->db, "DROP TRIGGER reject_avatar", NULL, NULL, NULL) == SQLITE_OK); retry(inst);
}
unsigned commits = 0; sqlite3_commit_hook(CC(inst)->db, veto, &commits); refused(inst); assert(commits == 1);
sqlite3_commit_hook(CC(inst)->db, NULL, NULL); retry(inst);
struct group_avatar_record r; candidate(inst, &r, 0); uint8_t before[32], after[32]; snapshot(reader, before); unsigned count = events;
target = "UPDATE channels SET avatar_version="; fault = F_FINALIZE;
assert(group_avatar_apply(inst, group_id, &r) < 0 && fault == F_NONE);
snapshot(reader, after); assert(!memcmp(before, after, 32) && events == count);
assert(group_avatar_apply(inst, group_id, &r) == 1 && events == count + 1);
assert(group_avatar_apply(inst, group_id, &r) == 0 && events == count + 1);
assert(sqlite3_exec(CC(inst)->db, "BEGIN;INSERT INTO ui_state(key,value) VALUES('foreign-avatar','1')", NULL, NULL, NULL) == SQLITE_OK);
snapshot(reader, before); count = events;
assert(group_avatar_apply(inst, group_id, &r) < 0 && group_avatar_set(inst, group_id, r.data, r.size) < 0);
assert(!sqlite3_get_autocommit(CC(inst)->db)); snapshot(reader, after);
assert(!memcmp(before, after, 32) && count == events);
assert(sqlite3_exec(CC(inst)->db, "ROLLBACK", NULL, NULL, NULL) == SQLITE_OK);
commits = 0; sqlite3_commit_hook(CC(inst)->db, veto, &commits);
assert(!group_avatar_set(inst, group_id, r.data, r.size) && events == count && !commits);
sqlite3_commit_hook(CC(inst)->db, NULL, NULL);
candidate(inst, &r, INT64_MAX); assert(group_avatar_apply(inst, group_id, &r) == 1);
count = events; assert(!group_avatar_set(inst, group_id, r.data, r.size) && events == count); refused(inst);
DEBUG_INFO(DEBUG_CATEGORY_CHAT, "PASS avatar SQL:%u faults/retries,signing,ABORT/IGNORE/veto,apply retry,foreign/no-op,max version; committed bytes/events preserved", cases);
}
static void reader_regressions(struct UTUN_INSTANCE* inst) {
struct group_avatar_record output, previous; memset(&previous, 0xa5, sizeof(previous));
const char* queries[] = {"SELECT avatar_version,avatar_data", "SELECT name, owner_node_id"};
unsigned cases = 0;
for (unsigned query = 0; query < 2; query++) {
target = queries[query];
for (enum fault point = F_PREPARE; point <= F_FINALIZE; point++) {
if (point == F_CHANGES) continue;
output = previous; bind_index = 1; fault = point;
assert(group_avatar_get(inst, group_id, &output) < 0 && fault == F_NONE && !memcmp(&output, &previous, sizeof(output)));
assert(!group_avatar_get(inst, group_id, &output)); cases++;
}
}
char channel[32]; ga_channel(group_id, channel); uint8_t x[32], ed[32], untouched[32]; memset(untouched, 0xa5, sizeof(untouched));
const char* keys[] = {"SELECT ed25519_privkey FROM channels", "SELECT x25519_privkey, ed25519_privkey FROM channels"};
for (unsigned pair = 0; pair < 2; pair++) {
target = keys[pair];
for (enum fault point = F_PREPARE; point <= F_FINALIZE; point++) {
if (point == F_CHANGES) continue;
memcpy(x, untouched, 32); memcpy(ed, untouched, 32); bind_index = 1; fault = point;
int rc = pair ? topo_node_sqlite_channel_get_privs(CC(inst)->db, channel, x, ed) :
topo_node_sqlite_channel_get_priv(CC(inst)->db, channel, ed);
assert(rc < 0 && fault == F_NONE && !memcmp(x, untouched, 32) && !memcmp(ed, untouched, 32));
assert(!topo_node_sqlite_channel_get_privs(CC(inst)->db, channel, x, ed)); cases++;
}
}
const char* corrupt[] = {"NULL", "zeroblob(31)", "zeroblob(33)", "printf('%032d',1)"};
for (unsigned i = 0; i < sizeof(corrupt) / sizeof(corrupt[0]); i++) {
char sql[256]; snprintf(sql, sizeof(sql), "BEGIN;UPDATE channels SET ed25519_privkey=%s WHERE channel_id='%s'", corrupt[i], channel);
assert(sqlite3_exec(CC(inst)->db, sql, NULL, NULL, NULL) == SQLITE_OK);
memcpy(x, untouched, 32); memcpy(ed, untouched, 32);
assert(topo_node_sqlite_channel_get_priv(CC(inst)->db, channel, ed) < 0 && !memcmp(ed, untouched, 32));
assert(topo_node_sqlite_channel_get_privs(CC(inst)->db, channel, x, ed) < 0 && !memcmp(ed, untouched, 32) && !memcmp(x, untouched, 32));
assert(sqlite3_exec(CC(inst)->db, "ROLLBACK", NULL, NULL, NULL) == SQLITE_OK);
}
DEBUG_INFO(DEBUG_CATEGORY_CHAT, "PASS avatar/key readers:%u SQL faults/retries,unchanged outputs,NULL/31/33/TEXT keys rejected", cases);
}
static int columns(sqlite3* db) {
sqlite3_stmt* st = NULL;
assert(sqlite3_prepare_v2(db, "SELECT count(*) FROM pragma_table_info('channels')", -1, &st, NULL) == SQLITE_OK);
assert(sqlite3_step(st) == SQLITE_ROW); int count = sqlite3_column_int(st, 0); assert(sqlite3_finalize(st) == SQLITE_OK); return count;
}
static void schema_base(sqlite3* db) {
assert(sqlite3_exec(db, "CREATE TABLE channels(channel_id TEXT PRIMARY KEY,name TEXT,ed25519_privkey BLOB);"
"INSERT INTO channels VALUES('42','retained',zeroblob(32))", NULL, NULL, NULL) == SQLITE_OK);
}
static void schema_regressions(const char* directory) {
const char* queries[] = {"PRAGMA table_info(channels)", "PRAGMA table_info(channels)", "PRAGMA table_info(channels)",
"SAVEPOINT group_avatar_schema", "ALTER TABLE channels ADD COLUMN avatar_version", "ALTER TABLE channels ADD COLUMN avatar_data",
"ALTER TABLE channels ADD COLUMN avatar_hash", "ALTER TABLE channels ADD COLUMN avatar_signature", "RELEASE group_avatar_schema"};
const enum fault points[] = {F_PREPARE, F_STEP, F_FINALIZE, F_EXEC, F_EXEC, F_EXEC, F_EXEC, F_EXEC, F_EXEC};
for (unsigned i = 0; i < sizeof(points) / sizeof(points[0]); i++) {
sqlite3* db = NULL; assert(sqlite3_open(":memory:", &db) == SQLITE_OK); schema_base(db); target = queries[i]; fault = points[i];
assert(group_avatar_schema_init(db) < 0 && fault == F_NONE && sqlite3_get_autocommit(db) && columns(db) == 3);
assert(!group_avatar_schema_init(db) && columns(db) == 7 && !group_avatar_schema_init(db)); assert(sqlite3_close(db) == SQLITE_OK);
}
sqlite3 *db = NULL, *view = NULL; char path[512]; snprintf(path, sizeof(path), "%s/schema.db", directory);
assert(sqlite3_open(path, &db) == SQLITE_OK); schema_base(db);
assert(sqlite3_open_v2(path, &view, SQLITE_OPEN_READONLY, NULL) == SQLITE_OK);
unsigned commits = 0; sqlite3_commit_hook(db, veto, &commits);
assert(group_avatar_schema_init(db) < 0 && commits == 1 && sqlite3_get_autocommit(db) && columns(view) == 3);
sqlite3_commit_hook(db, NULL, NULL);
target = "ALTER TABLE channels ADD COLUMN avatar_data"; fault = F_EXEC; fail_schema_rollback = 1; releases_after_failed_rollback = 1;
assert(group_avatar_schema_init(db) < 0 && fault == F_NONE && !fail_schema_rollback && !sqlite3_get_autocommit(db));
assert(releases_after_failed_rollback == 1 && columns(db) == 4 && columns(view) == 3); releases_after_failed_rollback = 0;
assert(sqlite3_close(db) == SQLITE_OK && columns(view) == 3 && sqlite3_close(view) == SQLITE_OK);
assert(sqlite3_open(path, &db) == SQLITE_OK && !group_avatar_schema_init(db) && columns(db) == 7 && sqlite3_close(db) == SQLITE_OK);
DEBUG_INFO(DEBUG_CATEGORY_CHAT, "PASS avatar schema:9 SQL faults/retries,commit veto,failed ROLLBACK TO never RELEASEs partial ALTER;owner close restores old schema");
}
int main(void) {
debug_config_init(); debug_set_level(DEBUG_LEVEL_ERROR); debug_set_category_level(DEBUG_CATEGORY_CHAT, DEBUG_LEVEL_INFO);
size_t baseline = u_get_allocated_count(); utun_instance_set_tun_init_enabled(0);
char directory[] = "/tmp/utun-avatar-sql-XXXXXX"; assert(mkdtemp(directory));
char config[512]; snprintf(config, sizeof(config), "[global]\ndb_path=%s\n[ntp]\nenabled=no\n"
char config[512], database[512]; snprintf(config, sizeof(config), "[global]\ndb_path=%s\n[ntp]\nenabled=no\n"
"[chatserver]\ngroup_autoconnect=0\nstorage_autoload=0\n", directory);
struct UASYNC* ua = uasync_create(); assert(ua);
struct UTUN_INSTANCE* inst = utun_instance_create_from_str(ua, config);
assert(inst && !utun_core_start(inst) && !chat_service_start(inst));
uint64_t group = chat_core_create_channel_auto(inst, "avatar SQL"); assert(group);
group_id = chat_core_create_channel_auto(inst, "avatar SQL"); assert(group_id);
snprintf(database, sizeof(database), "%s/chats.db", directory);
assert(sqlite3_open_v2(database, &reader, SQLITE_OPEN_READONLY, NULL) == SQLITE_OK);
chat_event_set_handler(inst, event);
const uint8_t image[] = {1, 2, 3}; fail_hash = 1;
int rc = group_avatar_set(inst, group, image, sizeof(image));
int rc = group_avatar_set(inst, group_id, image, sizeof(image));
DEBUG_INFO(DEBUG_CATEGORY_CHAT, "avatar test: hash bind failure result=%d events=%u fault_pending=%d", rc, events, fail_hash);
assert(rc < 0 && !events && !fail_hash);
struct group_avatar_record current; assert(!group_avatar_get(inst, group, &current) && !current.version);
assert(!group_avatar_set(inst, group, image, sizeof(image)) && events == 1);
utun_instance_destroy(inst); uasync_poll(ua, 0); uasync_destroy(ua, 0); assert(u_get_allocated_count() == baseline);
struct group_avatar_record current; assert(!group_avatar_get(inst, group_id, &current) && !current.version);
assert(!group_avatar_set(inst, group_id, image, sizeof(image)) && events == 1);
reader_regressions(inst); sql_regressions(inst); schema_regressions(directory);
uint8_t before[32], after[32]; snapshot(reader, before); unsigned count = events;
target = "SELECT avatar_version,avatar_data"; fault = F_STEP; fail_rollback = 1; inst->running = 1;
assert(publish(inst) < 0 && fault == F_NONE && !fail_rollback && !inst->running && !sqlite3_get_autocommit(CC(inst)->db));
snapshot(reader, after); assert(!memcmp(before, after, 32) && events == count);
utun_instance_destroy(inst); snapshot(reader, after); assert(!memcmp(before, after, 32) && sqlite3_close(reader) == SQLITE_OK);
uasync_poll(ua, 0); uasync_destroy(ua, 0); assert(u_get_allocated_count() == baseline);
DEBUG_INFO(DEBUG_CATEGORY_CHAT, "PASS avatar SQL rollback and successful retry"); return 0;
}