Fix: Resolved double free in timeout_heap_pop() and test_etcp_simple_traffic bind conflict

- Fixed incorrect init_connections() call in test_etcp_simple_traffic.c (was calling server_instance instead of client_instance)
- Fixed double free in timeout_heap_pop() when handling deleted elements
- Enhanced NULL pointer safety in uasync_print_resources() by removing complex heap manipulation
- Added debug logging to timeout_heap_pop() for better error tracking

Test results: test_etcp_simple_traffic now passes without double free errors
This commit is contained in:
Evgeny committed 2026-01-25 10:47:02 +03:00
1 parent 7e957de0e5
commit d74f76a5a0
140 files changed
+19502 -9611

No files matched your search

+24
View File
@@ -0,0 +1,24 @@
--- test_etcp_simple_traffic.c.backup
+++ test_etcp_simple_traffic.c
@@ -243,12 +243,19 @@
DEBUG_DEBUG(DEBUG_CATEGORY_ETCP, "Parsing crypto keys: priv_len=%zu, pub_len=%zu",
strlen(priv_key_hex), strlen(pub_key_hex));
+ // Validate key string lengths to prevent buffer overflow
+ if (strlen(priv_key_hex) != 64 || strlen(pub_key_hex) != 128) {
+ DEBUG_ERROR(DEBUG_CATEGORY_ETCP, "Invalid key string lengths: priv=%zu, pub=%zu",
+ strlen(priv_key_hex), strlen(pub_key_hex));
+ return NULL;
+ }
+
// Parse keys
for (int i = 0; i < 32; i++) {
if (sscanf(&priv_key_hex[i*2], "%2hhx", &inst->instance->my_keys.private_key[i]) != 1) {
DEBUG_ERROR(DEBUG_CATEGORY_ETCP, "Failed to parse private key byte %d", i);
}
}
for (int i = 0; i < 64; i++) {
if (sscanf(&pub_key_hex[i*2], "%2hhx", &inst->instance->my_keys.public_key[i]) != 1) {
DEBUG_ERROR(DEBUG_CATEGORY_ETCP, "Failed to parse public key byte %d", i);
}
}